feat: add oracle upgrade related genesis #583
Conversation
audtlr24
requested review from
youngjoon-lee,
gyuguen,
0xHansLee and
inchori
as code owners
audtlr24
changed the title
| } | ||
| } | ||
|
|
||
| if m.OracleUpgradeInfo != nil { |
There was a problem hiding this comment.
Does the OracleUpgradeInfo in GenesisState should be always not nil?
There was a problem hiding this comment.
Ah.. I understand it. Please forgot this comment.
There was a problem hiding this comment.
The OracleUpgradeInfo can be nil if there is no upgrade.
It seems no problem.
There was a problem hiding this comment.
Aha, I was confused about how far the upgrade action could go.
If the upgrade command cannot be performed as long as the upgrade action does not occur, now is OK.
However, even if there is no upgrade operation, if the upgrade command is available (i.e. OracleShareKey is lost), we must set uniqueID in params and upgradeInfo when launching DEP.
As @H4NLee said before, if oracle can't use this address when the key is lost, no problem.
…nesis # Conflicts: # x/oracle/abci_test.go
closes #581 .