feat: add set oracles at ApplyUpgrade #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Youngjoon Lee <taxihighway@gmail.com>
…nto ft/569/oracle-upgrade-handler # Conflicts: # cmd/panacead/cmd/genoracle.go # proto/panacea/oracle/v2/oracle.proto
…nto ft/570/upgrade-endblocker
…ft/571/upgrade-oracle-tx # Conflicts: # proto/panacea/oracle/v2/oracle.proto # proto/panacea/oracle/v2/proposal.proto # proto/panacea/oracle/v2/query.proto # x/oracle/types/errors.go # x/oracle/types/keys.go # x/oracle/types/oracle.go # x/oracle/types/oracle.pb.go # x/oracle/types/query.pb.go # x/oracle/types/query.pb.gw.go
…ft/575/upgrade-proto # Conflicts: # proto/panacea/oracle/v2/oracle.proto # proto/panacea/oracle/v2/proposal.proto # proto/panacea/oracle/v2/query.proto # x/oracle/types/keys.go # x/oracle/types/oracle.pb.go # x/oracle/types/query.pb.go # x/oracle/types/query.pb.gw.go
This reverts commit 44a3f47.
…upgrade" This reverts commit f73a2ca.
…1/upgrade-oracle-tx # Conflicts: # proto/panacea/oracle/v2/oracle.proto # proto/panacea/oracle/v2/proposal.proto # x/oracle/keeper/grpc_query_oracle.go # x/oracle/types/keys.go # x/oracle/types/oracle.pb.go
This reverts commit b54727f.
audtlr24
requested review from
cl9200,
youngjoon-lee,
gyuguen,
0xHansLee and
inchori
as code owners
gyuguen
approved these changes
Jan 3, 2023
x/oracle/keeper/upgrade.go
Outdated
Comment on lines
55
to
59
| uniqueID, address := types.SplitOracleUpgradeKey(iterator.Key()) | ||
| oracleUpgrade, err := k.GetOracleUpgrade(ctx, uniqueID, address.String()) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
I think you can change like below:
We don't have to called GetOracle(...) function.
Suggested change
| uniqueID, address := types.SplitOracleUpgradeKey(iterator.Key()) | |
| oracleUpgrade, err := k.GetOracleUpgrade(ctx, uniqueID, address.String()) | |
| if err != nil { | |
| return err | |
| } | |
| bz := iterator.Value() | |
| oracleUpgrade := &types.OracleUpgrade{} | |
| if err := k.cdc.UnmarshalLengthPrefixed(bz, oracleUpgrade); err != nil { | |
| return err | |
| } |
There was a problem hiding this comment.
I fixed it in 0e5ad56. Please check again, thanks.
…pgrade-oracle # Conflicts: # x/oracle/abci_test.go # x/oracle/keeper/oracle_test.go # x/oracle/keeper/upgrade.go # x/oracle/types/errors.go # x/oracle/types/keys.go # x/oracle/types/oracle.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #582 (comment), instead of applying the queue as in PR #584, change it to check the
EncryptedOraclePrivKeyin theOracleUpgradestore.Existing PR #584 will be closed.