Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TargetUniqueId to ApprovalSharingOracleKey #589

Merged
merged 51 commits into from
Jan 4, 2023

Conversation

0xHansLee
Copy link
Contributor

close #587

audtlr24 and others added 30 commits December 19, 2022 10:28
Co-authored-by: Youngjoon Lee <taxihighway@gmail.com>
…nto ft/569/oracle-upgrade-handler

# Conflicts:
#	cmd/panacead/cmd/genoracle.go
#	proto/panacea/oracle/v2/oracle.proto
…ft/571/upgrade-oracle-tx

# Conflicts:
#	proto/panacea/oracle/v2/oracle.proto
#	proto/panacea/oracle/v2/proposal.proto
#	proto/panacea/oracle/v2/query.proto
#	x/oracle/types/errors.go
#	x/oracle/types/keys.go
#	x/oracle/types/oracle.go
#	x/oracle/types/oracle.pb.go
#	x/oracle/types/query.pb.go
#	x/oracle/types/query.pb.gw.go
…ft/575/upgrade-proto

# Conflicts:
#	proto/panacea/oracle/v2/oracle.proto
#	proto/panacea/oracle/v2/proposal.proto
#	proto/panacea/oracle/v2/query.proto
#	x/oracle/types/keys.go
#	x/oracle/types/oracle.pb.go
#	x/oracle/types/query.pb.go
#	x/oracle/types/query.pb.gw.go
This reverts commit 44a3f47.
…1/upgrade-oracle-tx

# Conflicts:
#	proto/panacea/oracle/v2/oracle.proto
#	proto/panacea/oracle/v2/proposal.proto
#	x/oracle/keeper/grpc_query_oracle.go
#	x/oracle/types/keys.go
#	x/oracle/types/oracle.pb.go
@0xHansLee 0xHansLee self-assigned this Jan 3, 2023
@0xHansLee 0xHansLee marked this pull request as ready for review January 3, 2023 08:58
@0xHansLee 0xHansLee linked an issue Jan 3, 2023 that may be closed by this pull request
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think it would be good to add a test where targetUniqueID and uniqueID in upgradeInfo are not equal.

@0xHansLee
Copy link
Contributor Author

I think it would be good to add a test where targetUniqueID and uniqueID in upgradeInfo are not equal.

Good. I'll cover it soon!

Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngjoon-lee youngjoon-lee added this to the v2.1.0-beta milestone Jan 4, 2023
Base automatically changed from ft/na/improve-apply-upgrade-oracle to main January 4, 2023 07:36
…cle-unique-id

# Conflicts:
#	proto/panacea/oracle/v2/tx.proto
#	x/oracle/abci_test.go
#	x/oracle/keeper/oracle.go
#	x/oracle/keeper/oracle_test.go
#	x/oracle/keeper/upgrade.go
#	x/oracle/keeper/upgrade_test.go
#	x/oracle/types/errors.go
#	x/oracle/types/message_oracle.go
#	x/oracle/types/oracle.go
#	x/oracle/types/tx.pb.go
@0xHansLee 0xHansLee merged commit e5cc1c5 into main Jan 4, 2023
@0xHansLee 0xHansLee deleted the ft/587/add-target-oracle-unique-id branch January 4, 2023 08:14
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TargetOracleUniqueID to ApprovalSharingOracleKey
5 participants