-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TargetUniqueId
to ApprovalSharingOracleKey
#589
Conversation
Co-authored-by: Youngjoon Lee <taxihighway@gmail.com>
…nto ft/569/oracle-upgrade-handler # Conflicts: # cmd/panacead/cmd/genoracle.go # proto/panacea/oracle/v2/oracle.proto
…nto ft/570/upgrade-endblocker
…ft/571/upgrade-oracle-tx # Conflicts: # proto/panacea/oracle/v2/oracle.proto # proto/panacea/oracle/v2/proposal.proto # proto/panacea/oracle/v2/query.proto # x/oracle/types/errors.go # x/oracle/types/keys.go # x/oracle/types/oracle.go # x/oracle/types/oracle.pb.go # x/oracle/types/query.pb.go # x/oracle/types/query.pb.gw.go
…ft/575/upgrade-proto # Conflicts: # proto/panacea/oracle/v2/oracle.proto # proto/panacea/oracle/v2/proposal.proto # proto/panacea/oracle/v2/query.proto # x/oracle/types/keys.go # x/oracle/types/oracle.pb.go # x/oracle/types/query.pb.go # x/oracle/types/query.pb.gw.go
This reverts commit 44a3f47.
…upgrade" This reverts commit f73a2ca.
…1/upgrade-oracle-tx # Conflicts: # proto/panacea/oracle/v2/oracle.proto # proto/panacea/oracle/v2/proposal.proto # x/oracle/keeper/grpc_query_oracle.go # x/oracle/types/keys.go # x/oracle/types/oracle.pb.go
This reverts commit b54727f.
…get-oracle-unique-id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think it would be good to add a test where targetUniqueID and uniqueID in upgradeInfo are not equal.
Good. I'll cover it soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…cle-unique-id # Conflicts: # proto/panacea/oracle/v2/tx.proto # x/oracle/abci_test.go # x/oracle/keeper/oracle.go # x/oracle/keeper/oracle_test.go # x/oracle/keeper/upgrade.go # x/oracle/keeper/upgrade_test.go # x/oracle/types/errors.go # x/oracle/types/message_oracle.go # x/oracle/types/oracle.go # x/oracle/types/tx.pb.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
close #587