Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add data provider consent spec for protocol devs #592

Merged
merged 6 commits into from
Jan 10, 2023

Conversation

0xHansLee
Copy link
Contributor

Based on #567, added specs of data provider consent for protocol devs

@0xHansLee 0xHansLee self-assigned this Jan 4, 2023
@0xHansLee 0xHansLee marked this pull request as ready for review January 4, 2023 06:46
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I have a question.

Do we call blockchain names a Panacea in docs?
I ask for unification to other documents as well.

Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@youngjoon-lee
Copy link
Contributor

Do we call blockchain names a Panacea in docs?
I ask for unification to other documents as well.

Yes. Let's use Panacea until we have a clear decision for naming. There are still so many discussions/feedbacks about naming, but it's not simple to decide within only the blockchain team.

@gyuguen
Copy link
Contributor

gyuguen commented Jan 5, 2023

Do we call blockchain names a Panacea in docs?
I ask for unification to other documents as well.

Yes. Let's use Panacea until we have a clear decision for naming. There are still so many discussions/feedbacks about naming, but it's not simple to decide within only the blockchain team.

OK. Thanks

Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xHansLee 0xHansLee merged commit a151c11 into docs/560 Jan 10, 2023
@0xHansLee 0xHansLee deleted the docs/submit-consent-protocol-devs branch January 10, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants