Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add user guide for provider #594

Merged
merged 7 commits into from
Jan 10, 2023
Merged

docs: add user guide for provider #594

merged 7 commits into from
Jan 10, 2023

Conversation

audtlr24
Copy link
Contributor

@audtlr24 audtlr24 commented Jan 4, 2023

Based on #567, added user guide for providers.

@audtlr24 audtlr24 self-assigned this Jan 4, 2023
gyuguen
gyuguen approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I left some comment.

.gitbook/1-users/3-data-exchange/2-provide-data.md Show resolved Hide resolved
.gitbook/1-users/3-data-exchange/2-provide-data.md Show resolved Hide resolved
youngjoon-lee
youngjoon-lee approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lggtm

.gitbook/1-users/3-data-exchange/2-provide-data.md Outdated Show resolved Hide resolved
.gitbook/1-users/3-data-exchange/2-provide-data.md Outdated Show resolved Hide resolved
0xHansLee
0xHansLee reviewed Jan 6, 2023
View reviewed changes
.gitbook/1-users/3-data-exchange/2-provide-data.md Outdated Show resolved Hide resolved
.gitbook/1-users/3-data-exchange/2-provide-data.md Outdated Show resolved Hide resolved
.gitbook/1-users/3-data-exchange/2-provide-data.md Outdated Show resolved Hide resolved
.gitbook/1-users/3-data-exchange/2-provide-data.md Outdated Show resolved Hide resolved
.gitbook/1-users/3-data-exchange/2-provide-data.md Outdated Show resolved Hide resolved
.gitbook/1-users/3-data-exchange/2-provide-data.md Outdated Show resolved Hide resolved
.gitbook/1-users/3-data-exchange/2-provide-data.md Outdated Show resolved Hide resolved
.gitbook/1-users/3-data-exchange/2-provide-data.md Outdated Show resolved Hide resolved
.gitbook/1-users/3-data-exchange/2-provide-data.md Outdated Show resolved Hide resolved
.gitbook/1-users/3-data-exchange/2-provide-data.md Outdated Show resolved Hide resolved
inchori
inchori approved these changes Jan 6, 2023
View reviewed changes
Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.gitbook/1-users/3-data-exchange/2-provide-data.md Outdated Show resolved Hide resolved
@audtlr24
Copy link
Contributor Author

audtlr24 commented Jan 9, 2023

Thanks. I reflect all comments. Please review again.

0xHansLee
0xHansLee approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

inchori
inchori approved these changes Jan 9, 2023
View reviewed changes
Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

.gitbook/1-users/3-data-exchange/2-provide-data.md Outdated Show resolved Hide resolved
.gitbook/1-users/3-data-exchange/2-provide-data.md Outdated Show resolved Hide resolved
audtlr24 and others added 2 commits January 9, 2023 17:11
@audtlr24 @inchori
Update .gitbook/1-users/3-data-exchange/2-provide-data.md
01a7e08 
Co-authored-by: InChul <49394875+inchori@users.noreply.github.com>
@audtlr24 @inchori
Update .gitbook/1-users/3-data-exchange/2-provide-data.md
c3099a4 
Co-authored-by: InChul <49394875+inchori@users.noreply.github.com>
youngjoon-lee
youngjoon-lee approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gyuguen
gyuguen approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@audtlr24 audtlr24 merged commit d4976bd into docs/560 Jan 10, 2023
@audtlr24 audtlr24 deleted the docs/users-provide-data branch January 10, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inchori inchori inchori approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

@gyuguen gyuguen gyuguen approved these changes

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200

Assignees

@audtlr24 audtlr24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@audtlr24 @youngjoon-lee @gyuguen @0xHansLee @inchori