Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move handleOracleUpgrade to BeginBlock #598

Merged
merged 4 commits into from
Jan 9, 2023
Merged

feat: move handleOracleUpgrade to BeginBlock #598

merged 4 commits into from
Jan 9, 2023

Conversation

audtlr24
Copy link
Contributor

@audtlr24 audtlr24 commented Jan 5, 2023

Change EndBlocker to BeginBlocker, because ApplyUpgrade operates when the upgrade block height is reached.

@audtlr24 audtlr24 added this to the v2.1.0-beta milestone Jan 5, 2023
@audtlr24 audtlr24 self-assigned this Jan 5, 2023
gyuguen
gyuguen approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

youngjoon-lee
youngjoon-lee approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

0xHansLee
0xHansLee approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

inchori
inchori approved these changes Jan 6, 2023
View reviewed changes
Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@audtlr24 audtlr24 merged commit 1519f9d into main Jan 9, 2023
@audtlr24 audtlr24 deleted the ft/na/mv-oracle-upgrade-to-beginblocker branch January 9, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@gyuguen gyuguen gyuguen approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

@inchori inchori inchori approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

Assignees

@audtlr24 audtlr24

Labels
None yet
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.
5 participants
@audtlr24 @youngjoon-lee @gyuguen @0xHansLee @inchori