Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add terms of agreement #621

Merged
merged 2 commits into from
Jan 13, 2023
Merged

docs: add terms of agreement #621

merged 2 commits into from
Jan 13, 2023

Conversation

0xHansLee
Copy link
Contributor

No description provided.

@0xHansLee 0xHansLee added the documentation Improvements or additions to documentation label Jan 13, 2023
@0xHansLee 0xHansLee self-assigned this Jan 13, 2023
youngjoon-lee
youngjoon-lee approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gltm

gyuguen
gyuguen approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We're mixing ${name}, <name> for variables. Let's unite later

@0xHansLee
Copy link
Contributor Author

We're mixing ${name}, for variables. Let's unite later

I intentionally change to <deal_id>, because its type is uint. Regardless of the type, is it better to use like "{deal_id}"?

gyuguen
gyuguen reviewed Jan 13, 2023
View reviewed changes
.gitbook/1-users/3-data-exchange/2-provide-data.md
```bash
panacead submit-consent ${certificate-file-path} \
panacead submit-consent ${consent-file-path} \
--from ${data-provider-addr} \
--chain-id ${chain-id} \
--gas auto --gas-adjustment 1.30 --gas-prices 5umed \
Copy link
Contributor

@gyuguen gyuguen Jan 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is what I was talking about. :)

inchori
inchori approved these changes Jan 13, 2023
View reviewed changes
Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

audtlr24
audtlr24 approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xHansLee 0xHansLee merged commit d5b448c into docs/560 Jan 13, 2023
@0xHansLee 0xHansLee deleted the docs-na-fix-submit-consent branch January 13, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyuguen gyuguen gyuguen approved these changes

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@inchori inchori inchori approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200

Assignees

@0xHansLee 0xHansLee

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v2.1.0-beta.3: Documentation
Development

Successfully merging this pull request may close these issues.
5 participants
@0xHansLee @youngjoon-lee @gyuguen @audtlr24 @inchori