feat: Bump Cosmos SDK to v0.47.10

.github/workflows/ci.yml

@@ -17,14 +17,14 @@ jobs:
     - name: Set up Go 1.x
       uses: actions/setup-go@v3
       with:
-        go-version: 1.19
+        go-version: 1.22
       id: go
 
     - name: Check out code into the Go module directory
       uses: actions/checkout@v3
 
     - name: Build (+ generating proto and docs)
-      run: make build-all
+      run: make all
 
     - name: Test
       run: make test

Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.19.2-bullseye AS build-env
+FROM golang:1.22.0-bullseye AS build-env
 
 # Install minimum necessary dependencies,
 ENV PACKAGES make git gcc

Makefile

@@ -1,107 +1,198 @@
-VERSION := $(shell echo $(shell git describe --tags) | sed 's/^v//')
-COMMIT := $(shell git log -1 --format='%H')
-GOBIN ?= $(GOPATH)/bin
-GOSUM := $(shell which gosum)
+export VERSION := $(shell echo $(shell git describe --always --match "v*") | sed 's/^v//')
+export TMVERSION := $(shell go list -m github.com/cometbft/cometbft | sed 's:.* ::')
+export COMMIT := $(shell git log -1 --format='%H')
+LEDGER_ENABLED ?= true
+BINDIR ?= $(GOPATH)/bin
+BUILDDIR ?= $(CURDIR)/build
+HTTPS_GIT := https://github.com/medibloc/panacea-core.git
 DOCKER := $(shell which docker)
+DOCKER_BUF := $(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace bufbuild/buf:1.0.0-rc8
+PROJECT_NAME = $(shell git remote get-url origin | xargs basename -s .git)
+DOCS_DOMAIN=docs.gopanacea.org
 
 export GO111MODULE = on
 
+# process build tags
+build_tags = netgo
+ifeq ($(LEDGER_ENABLED),true)
+  ifeq ($(OS),Windows_NT)
+    GCCEXE = $(shell where gcc.exe 2> NUL)
+    ifeq ($(GCCEXE),)
+      $(error gcc.exe not installed for ledger support, please install or set LEDGER_ENABLED=false)
+    else
+      build_tags += ledger
+    endif
+  else
+    UNAME_S = $(shell uname -s)
+    ifeq ($(UNAME_S),OpenBSD)
+      $(warning OpenBSD detected, disabling ledger support (https://github.com/cosmos/cosmos-sdk/issues/1988))
+    else
+      GCC = $(shell command -v gcc 2> /dev/null)
+      ifeq ($(GCC),)
+        $(error gcc not installed for ledger support, please install or set LEDGER_ENABLED=false)
+      else
+        build_tags += ledger
+      endif
+    endif
+  endif
+endif
 
-ifeq ($(WITH_CLEVELDB),yes)
-  build_tags += gcc
+ifeq (secp,$(findstring secp,$(COSMOS_BUILD_OPTIONS)))
+  build_tags += libsecp256k1_sdk
 endif
-build_tags += $(BUILD_TAGS)
-build_tags := $(strip $(build_tags))
-build_tags += ledger
+
+whitespace :=
+whitespace += $(whitespace)
+comma := ,
+build_tags_comma_sep := $(subst $(whitespace),$(comma),$(build_tags))
 
 # process linker flags
 
 ldflags = -X github.com/cosmos/cosmos-sdk/version.Name=panacea-core \
-          -X github.com/cosmos/cosmos-sdk/version.ServerName=panacead \
-          -X github.com/cosmos/cosmos-sdk/version.ClientName=panaceacli \
-          -X github.com/cosmos/cosmos-sdk/version.Version=$(VERSION) \
-          -X github.com/cosmos/cosmos-sdk/version.Commit=$(COMMIT) \
-          -X "github.com/cosmos/cosmos-sdk/version.BuildTags=$(build_tags)"
+		  -X github.com/cosmos/cosmos-sdk/version.AppName=panacead \
+		  -X github.com/cosmos/cosmos-sdk/version.Version=$(VERSION) \
+		  -X github.com/cosmos/cosmos-sdk/version.Commit=$(COMMIT) \
+		  -X "github.com/cosmos/cosmos-sdk/version.BuildTags=$(build_tags_comma_sep)" \
+		  -X github.com/tendermint/tendermint/version.TMCoreSemVer=$(TMVERSION)
+
+ARTIFACT_DIR := artifacts
+
+# DB backend selection
+ifeq (cleveldb,$(findstring cleveldb,$(COSMOS_BUILD_OPTIONS)))
+  build_tags += gcc
+endif
+ifeq (badgerdb,$(findstring badgerdb,$(COSMOS_BUILD_OPTIONS)))
+  build_tags += badgerdb
+endif
+# handle rocksdb
+ifeq (rocksdb,$(findstring rocksdb,$(COSMOS_BUILD_OPTIONS)))
+  CGO_ENABLED=1
+  build_tags += rocksdb
+endif
+# handle boltdb
+ifeq (boltdb,$(findstring boltdb,$(COSMOS_BUILD_OPTIONS)))
+  build_tags += boltdb
+endif
 
-ldflags += $(LDFLAGS)
+ifeq (,$(findstring nostrip,$(COSMOS_BUILD_OPTIONS)))
+  ldflags += -w -s
+endif
+#ldflags += $(LDFLAGS)
 ldflags := $(strip $(ldflags))
+
+build_tags += $(BUILD_TAGS)
+build_tags := $(strip $(build_tags))
+
 BUILD_FLAGS := -tags "$(build_tags)" -ldflags '$(ldflags)'
+# check for nostrip option
+ifeq (,$(findstring nostrip,$(COSMOS_BUILD_OPTIONS)))
+  BUILD_FLAGS += -trimpath
+endif
 
-ARTIFACT_DIR := artifacts
+# Check for debug option
+ifeq (debug,$(findstring debug,$(COSMOS_BUILD_OPTIONS)))
+  BUILD_FLAGS += -gcflags "all=-N -l"
+endif
 
-all: build-all install
-build-all: proto-lint proto-gen update-swagger-docs build
+all: build lint test
+###############################################################################
+###                                  Build                                  ###
+###############################################################################
 
-########################################
-### Analyzing
+BUILD_TARGETS := build install
 
-lint:
-	GO111MODULE=off go get github.com/golangci/golangci-lint/cmd/golangci-lint
-	golangci-lint run --timeout 5m0s --allow-parallel-runners
-	find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" | xargs gofmt -d -s
+build: BUILD_ARGS=-o $(BUILDDIR)/
+build-linux:
+	GOOS=linux GOARCH=$(if $(findstring aarch64,$(shell uname -m)) || $(findstring arm64,$(shell uname -m)),arm64,amd64) LEDGER_ENABLED=false $(MAKE) build
+
+test:
+	mkdir -p $(ARTIFACT_DIR)
+	go test -covermode=count -coverprofile=$(ARTIFACT_DIR)/coverage.out ./...
+	go tool cover -html=$(ARTIFACT_DIR)/coverage.out -o $(ARTIFACT_DIR)/coverage.html
+
+$(BUILD_TARGETS): go.sum $(BUILDDIR)/
+	go $@ -mod=readonly $(BUILD_FLAGS) $(BUILD_ARGS) ./...
+
+$(BUILDDIR)/:
+	mkdir -p $(BUILDDIR)/
+
+.PHONY: build build-linux
+
+distclean: clean tools-clean
+clean:
+	rm -rf \
+    $(BUILDDIR)/ \
+    artifacts/ \
+    tmp-swagger-gen/
+
+.PHONY: distclean clean
+
+
+###############################################################################
+###                          Tools & Dependencies                           ###
+###############################################################################
+
+go.sum: go.mod
+	echo "Ensure dependencies have not been modified ..." >&2
 	go mod verify
+	go mod tidy
 
-########################################
-### Protobuf
+###############################################################################
+###                                Linting                                  ###
+###############################################################################
 
-proto-gen:
-	@echo "Generating *.pb.go files from *.proto files"
-	$(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace tendermintdev/sdk-proto-gen:v0.2 sh ./scripts/protocgen.sh
+golangci_lint_cmd=golangci-lint
+golangci_version=v1.56.2
 
-proto-swagger-gen:
-	@echo "Generating swagger.yaml from *.proto files"
-	$(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace tendermintdev/sdk-proto-gen:v0.2 sh ./scripts/protoc-swagger-gen.sh
+lint:
+	@echo "--> Running linter"
+	@go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(golangci_version)
+	@$(golangci_lint_cmd) run --timeout=10m
 
-proto-lint:
-	$(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace bufbuild/buf lint --error-format=json
+lint-fix:
+	@echo "--> Running linter"
+	@go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(golangci_version)
+	@$(golangci_lint_cmd) run --fix --out-format=tab --issues-exit-code=0
 
-PROTO_DIR = third_party/proto
-# TODO: use the correct version after releasing medibloc/cosmos-sdk
-COSMOS_VER_SHORT = 0.42.11-panacea-min-commission-rate-28eaec9
-COSMOS_VER = v$(COSMOS_VER_SHORT)
+.PHONY: lint lint-fix
 
-proto-update-dep:
-	@mkdir -p $(PROTO_DIR)
-	@curl https://codeload.github.com/medibloc/cosmos-sdk/tar.gz/$(COSMOS_VER) | tar -xz -C $(PROTO_DIR) --strip=3 cosmos-sdk-$(COSMOS_VER_SHORT)/third_party/proto
-	@curl https://codeload.github.com/medibloc/cosmos-sdk/tar.gz/$(COSMOS_VER) | tar -xz -C $(PROTO_DIR) --strip=2 cosmos-sdk-$(COSMOS_VER_SHORT)/proto
+format:
+	@go install mvdan.cc/gofumpt@latest
+	@go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(golangci_version)
+	find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" -not -path "./client/docs/statik/statik.go" -not -path "./tests/mocks/*" -not -name "*.pb.go" -not -name "*.pb.gw.go" -not -name "*.pulsar.go" -not -path "./crypto/keys/secp256k1/*" | xargs gofumpt -w -l
+	golangci-lint run --fix
+.PHONY: format
 
-########################################
-### Build/Install
 
-build: go.sum
-	go build -mod=readonly $(BUILD_FLAGS) -o build/panacead ./cmd/panacead
+###############################################################################
+###                                Protobuf                                 ###
+###############################################################################
 
-test:
-	mkdir -p $(ARTIFACT_DIR)
-	go test -covermode=count -coverprofile=$(ARTIFACT_DIR)/coverage.out ./...
-	go tool cover -html=$(ARTIFACT_DIR)/coverage.out -o $(ARTIFACT_DIR)/coverage.html
+protoVer=0.13.0
+protoImageName=ghcr.io/cosmos/proto-builder:$(protoVer)
+protoImage=$(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace $(protoImageName)
 
-install: go.sum
-	go install -mod=readonly $(BUILD_FLAGS) ./cmd/panacead
+proto-all: proto-format proto-lint proto-gen
 
-go.sum: go.mod
-	@echo "--> Ensure dependencies have not been modified"
-	@go mod verify
+proto-gen:
+	@echo "Generating Protobuf files"
+	@$(protoImage) sh ./proto/scripts/protocgen.sh
 
-########################################
-### Documentations
+proto-swagger-gen:
+	@echo "Generating Protobuf Swagger"
+	@$(protoImage) sh ./proto/scripts/protoc-swagger-gen.sh
 
-update-swagger-docs: proto-swagger-gen
-	GO111MODULE=off go get github.com/rakyll/statik
+proto-format:
+	@$(protoImage) find ./ -name "*.proto" -exec clang-format -i {} \;
 
-	@echo "Generating swagger.go from swagger.yaml and other static files"
-	statik -src=client/docs/swagger-ui -dest=client/docs -f -m
+proto-lint:
+	@$(protoImage) buf lint --error-format=json
 
-	# The following 'git' command returns non-zero exit code when there are uncommitted changes.
-	@if [ -n "$(git status --porcelain)" ]; then \
-        echo "\033[91mSwagger docs are out of sync!!!\033[0m";\
-        exit 1;\
-    else \
-        echo "\033[92mSwagger docs are in sync\033[0m";\
-    fi
+proto-check-breaking:
+	@$(protoImage) buf breaking --against $(HTTPS_GIT)#branch=main
 
-########################################
-### Clean
+proto-update-deps:
+	@echo "Updating Protobuf dependencies"
+	$(DOCKER) run --rm -v $(CURDIR)/proto:/workspace --workdir /workspace $(protoImageName) buf mod update
 
-clean:
-	rm -rf build/
+.PHONY: proto-all proto-gen proto-swagger-gen proto-format proto-lint proto-check-breaking proto-update-deps