Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NetworkID from DIDs + Reorganize 'dist' structure #18

Merged
merged 5 commits into from
Oct 5, 2020

Conversation

youngjoon-lee
Copy link

@youngjoon-lee youngjoon-lee commented Sep 29, 2020

@youngjoon-lee youngjoon-lee changed the title Changes for the new DID format: No network ID Remove NetworkID from DIDs + Reorganize 'dist' structure Sep 30, 2020
"outDir": "dist", /* Redirect output structure to the directory. */
"rootDir": ".", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
"outDir": "dist", /* Redirect output structure to the directory. */
"rootDir": "src", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
Copy link
Author

@youngjoon-lee youngjoon-lee Sep 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the dist/ like:

dist/index.js
dist/...

Previously, it was:

dist/src/index.js
dist/src/...
dist/test/...

which is not compatible with our package.json. Also, we don't need to transcompile test/**/*.ts.

Reference: https://github.com/terra-project/terra.js/blob/41ffbd4f9a8d827f8df0764c98327ca8101e455e/tsconfig.json#L20

Copy link
Contributor

@cl9200 cl9200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youngjoon-lee youngjoon-lee merged commit ac515b2 into master Oct 5, 2020
@youngjoon-lee youngjoon-lee deleted the ft/na/new-did-format branch October 5, 2020 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants