Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stargate: Add GroupSigningPanaceaClient and its addRecordWithFeePayer() #41

Merged
merged 1 commit into from
Jul 6, 2021
Merged

feat: stargate: Add GroupSigningPanaceaClient and its addRecordWithFeePayer() #41

merged 1 commit into from
Jul 6, 2021

Conversation

youngjoon-lee
Copy link

  • For AddRecord with a fee payer, the group signing is required.
    • Added GroupSigningPanaceaClient
      • which extends SigningPanaceaClient
      • which has addRecordWithFeePayer()

Base automatically changed from ft/na/stargate-base-classes to stargate June 24, 2021 14:32
@youngjoon-lee
Copy link
Author

@gyuguen pls review this PR if you forgot :)

gyuguen
gyuguen approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gyuguen
Copy link
Contributor

gyuguen commented Jul 6, 2021

Sorry. I forget it. T_T

@youngjoon-lee youngjoon-lee merged commit 8bed9e8 into stargate Jul 6, 2021
@youngjoon-lee youngjoon-lee deleted the ft/na/group-signing branch July 6, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyuguen gyuguen gyuguen approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngjoon-lee @gyuguen