Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add explicit fee parameters #60

Merged
merged 5 commits into from
Jun 3, 2022
Merged

Conversation

youngjoon-lee
Copy link

@youngjoon-lee youngjoon-lee commented Jun 3, 2022

Previously, we've had the fee-table concept which is the default fees for each tx type. But from the latest cosmjs, the fee-table concept has been removed. So, I upgraded cosmjs, added explicit fee parameters, and enabled the gas estimation by setting the fee as "auto".

Youngjoon Lee added 2 commits June 3, 2022 11:17
@youngjoon-lee youngjoon-lee changed the title WIP: remove fee tables feat: add explicit fee parameters Jun 3, 2022
@youngjoon-lee youngjoon-lee self-assigned this Jun 3, 2022
@youngjoon-lee youngjoon-lee marked this pull request as ready for review June 3, 2022 03:41
Youngjoon Lee added 3 commits June 3, 2022 12:56
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
This is a great version change.

Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@youngjoon-lee youngjoon-lee merged commit ada80f8 into master Jun 3, 2022
@youngjoon-lee youngjoon-lee deleted the feat/na/fee-table branch June 3, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants