Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add maxConnections and maxRequestBodySize limit setting. #109

Merged
merged 7 commits into from
Mar 13, 2023
Merged

feat: add maxConnections and maxRequestBodySize limit setting. #109

merged 7 commits into from
Mar 13, 2023

Conversation

gyuguen
Copy link
Contributor

@gyuguen gyuguen commented Mar 13, 2023

close #108

@gyuguen gyuguen added this to the v0.0.1-alpha.2 milestone Mar 13, 2023
@gyuguen gyuguen self-assigned this Mar 13, 2023
@gyuguen
Copy link
Contributor Author

gyuguen commented Mar 13, 2023 •
edited
Loading

I draft this PR because the base branch release/v0.0.1 is out of data.

@gyuguen gyuguen marked this pull request as draft March 13, 2023 02:43
@gyuguen gyuguen force-pushed the ft/108/add_max_connections_and_max_request_body_size branch from 7743ffb to cad9208 Compare March 13, 2023 02:48
@gyuguen gyuguen marked this pull request as ready for review March 13, 2023 02:48
@gyuguen
Copy link
Contributor Author

gyuguen commented Mar 13, 2023

This PR is ready!

youngjoon-lee
youngjoon-lee approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

audtlr24
audtlr24 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gyuguen gyuguen merged commit 77938e9 into release/v0.0.1 Mar 13, 2023
@gyuguen gyuguen deleted the ft/108/add_max_connections_and_max_request_body_size branch March 13, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@0xHansLee 0xHansLee Awaiting requested review from 0xHansLee

@inchori inchori Awaiting requested review from inchori

Assignees

@gyuguen gyuguen

Labels
None yet
Projects
None yet
Milestone
v0.0.1-alpha.2
Development

Successfully merging this pull request may close these issues.
3 participants
@gyuguen @youngjoon-lee @audtlr24