feat: data validation handler #20
Conversation
Co-authored-by: Youngjoon Lee <yjlee@medibloc.org>
# Conflicts: # cmd/oracled/cmd/root.go # service/handler.go
# Conflicts: # go.mod # panacea/query_client.go
|
I have not tested full cycle of this handler because some relevant functions of Panacea are in developing. |
|
I can make test codes for this handler as youngjoon did for |
service/handler.go
Outdated
| ProviderAddress string `json:"provider_address"` | ||
| EncryptedDataBase64 string `json:"encrypted_data_base64"` | ||
| DataHash string `json:"data_hash"` | ||
| } | ||
|
|
There was a problem hiding this comment.
How about added validation function like func (m ValidateDataReq) ValidateBasic() {...}.
This is a validation of request parameters.
service/handler.go
Outdated
| http.Error(w, "failed to get deal", http.StatusBadRequest) | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
How about added validation a deal status?
There was a problem hiding this comment.
I'm approving merging this PR in general, but it seems there are some duplicated codes with PR #21, in regard to the AES encryption.
|
I tried to write test for this handler, but it requires to mock service, and many components inside service (query client, ipfs, etc.). |
Yup. No worries :) |
| ) | ||
|
|
||
| // Encrypt combines secretKey and secondKey to encrypt with AES256-GCM method. | ||
| func Encrypt(secretKey, additional, data []byte) ([]byte, error) { |
There was a problem hiding this comment.
Ah, If these functions are merged into main branch, I'll change it when executing approveOracleRegistration tx.
# Conflicts: # go.sum # panacea/query_client.go # server/middleware/auth_test.go
close #6