Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unique ID to data cert #26

Merged
merged 6 commits into from
Dec 14, 2022
Merged

Conversation

0xHansLee
Copy link
Contributor

Unique ID is added to UnsignedDataCertificate

@0xHansLee 0xHansLee added this to the v2.1.0-beta milestone Dec 13, 2022
@0xHansLee 0xHansLee self-assigned this Dec 13, 2022
@0xHansLee 0xHansLee marked this pull request as ready for review December 13, 2022 07:34
@0xHansLee 0xHansLee requested review from youngjoon-lee and removed request for tjyoon0324 December 13, 2022 07:34
Copy link
Contributor

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@gyuguen
Copy link
Contributor

gyuguen commented Dec 14, 2022

please check the code for error :)

@0xHansLee 0xHansLee merged commit a0e7681 into main Dec 14, 2022
@0xHansLee 0xHansLee deleted the fix/na/unsigned_cert_uniqueid branch December 14, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants