Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add PathEscape to GetStoreData key #53

Merged
merged 3 commits into from
Dec 21, 2022
Merged

feat: add PathEscape to GetStoreData key #53

merged 3 commits into from
Dec 21, 2022

Conversation

audtlr24
Copy link
Contributor

closes #50.

@audtlr24 audtlr24 added this to the v2.1.0-beta milestone Dec 20, 2022
@audtlr24 audtlr24 self-assigned this Dec 20, 2022
@audtlr24
Copy link
Contributor Author

audtlr24 commented Dec 20, 2022 •
edited
Loading

I will open the PR, after local test works well.

@audtlr24 audtlr24 marked this pull request as ready for review December 20, 2022 07:24
gyuguen
gyuguen approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@audtlr24
Copy link
Contributor Author

I test it and it works well for the address where the error occurred.

0xHansLee
0xHansLee approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

youngjoon-lee
youngjoon-lee approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gltm

@audtlr24 audtlr24 merged commit 11d5e64 into main Dec 21, 2022
@audtlr24 audtlr24 deleted the ft/na/add-path-escape branch December 21, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@gyuguen gyuguen gyuguen approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200

@inchori inchori Awaiting requested review from inchori

Assignees

@audtlr24 audtlr24

Labels
None yet
Projects
None yet
Milestone
v0.0.1-alpha.1
Development

Successfully merging this pull request may close these issues.

Add PathEscape to MerklePath key
4 participants
@audtlr24 @youngjoon-lee @gyuguen @0xHansLee