Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add TargetOracleUniqueID to ApprovalSharingOracleKey #63

Merged
merged 2 commits into from
Jan 4, 2023
Merged

feat: add TargetOracleUniqueID to ApprovalSharingOracleKey #63

merged 2 commits into from
Jan 4, 2023

Conversation

0xHansLee
Copy link
Contributor

close #62

@0xHansLee 0xHansLee self-assigned this Jan 3, 2023
gyuguen
gyuguen approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

audtlr24
audtlr24 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

inchori
inchori approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xHansLee 0xHansLee merged commit e952de1 into main Jan 4, 2023
@0xHansLee 0xHansLee deleted the ft/62 branch January 4, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inchori inchori inchori approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@gyuguen gyuguen gyuguen approved these changes

@youngjoon-lee youngjoon-lee Awaiting requested review from youngjoon-lee

Assignees

@0xHansLee 0xHansLee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TargetOracleUniqueID when approving of sharing oracle priv key
4 participants
@0xHansLee @gyuguen @audtlr24 @inchori