Allow configuring of whitelabelling options

[garethbowen]

We added a feature in 3.4.0 to allow for configuration of the app logo, favicon, title, and to add partner icons to the About page. These are configurable through the admin app but we should make sure these can be stored in the configuration structure and uploaded by medic-conf with the rest of the settings.

Also update the configuration documentation here: https://github.com/medic/medic-docs/blob/master/configuration/developing-community-health-applications.md#graphics

Feature issues: medic/cht-core#4849 and medic/cht-core#4850

[garethbowen]

Blocked waiting for this to be merged: #196

[garethbowen]

Not yet started - delaying to 3.9.0

[latin-panda]

Hi @garethbowen, The ticket says to update the documentation, but I remember it got moved to CHT community. Should I update both places?

[garethbowen]

Good question! medic-docs is archived and will be deleted at some point, so you don't need to update it. Just update the cht-docs version, thanks!

[garethbowen]

Ready for AT in 167-upload-branding. Documentation change here: medic/cht-docs#234

[newtewt]

@latin-panda This is working as intended but there are some side affects coming from this. These might be issues that are for a new github issue but are now being exposed because of this new functionality.

If I upload an image using medic-conf to partners. Then remove that partner from the partners.json and upload again. The attachment still lives in the doc in couchdb. It doesn't get displayed in the app in partners config or about page. However, looking at the network calls we are still sending that image just not rendering it.

We also don't seem to be doing any sort of type checking. I set a json file to be uploaded. The webapp displays the broken image icon and looking at network console it displays the json file.

Example partners.json file.

  "resources": {
    "River Side": "riverside.png",
    "OhioHealth": "ohiohealth.json",
    "grant": "grant.png"
  }
}

[latin-panda]

Hi @newtewt, I have updated the PR :)
Regarding # 1: This issue currently exists in master. I added a filter to check and discard attachments that aren't mentioned in the settings json. Since this is a common functionally, the affected actions are: upload-branding, upload-partners and upload-resources only.

Regarding # 2: This issue could potentially be side effect of the PR on attachments feature for files that aren't image or json, but json files were accepted since before probably as part of another action (?). Gareth advices to take this one as part of another ticket, then we can identify the related actions commands and come up with a solution :)

[newtewt]

Cool @latin-panda, I've reviewed after these new changes. I think we can close this one out.

Confirmed that uploading branding and partners logos is possible via medic-conf. Confirmed it still works via the admin page. Validated that removing partners and branding now removes from the attachment doc.

[latin-panda]

@newtewt I have added an issue for # 2: #364 👍