Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

269 - Log warning for deprecated transitions #338

Merged
merged 3 commits into from
Sep 14, 2020

Conversation

latin-panda
Copy link
Contributor

Description

Adding a call to the Deprecated Transition GET endpoint and log a warning if any of the new settings is enabling a deprecated transition.

#269

Code review items

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on medic-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in Changes.md.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

…ions are activated when uploading app settings.
Copy link
Member

@dianabarsan dianabarsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left a couple of comments inline.

src/lib/api.js Show resolved Hide resolved
src/lib/api.js Outdated Show resolved Hide resolved
src/lib/api.js Outdated Show resolved Hide resolved
Copy link
Member

@dianabarsan dianabarsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I left one minor performance optimization nit inline.

src/lib/api.js Outdated Show resolved Hide resolved
…ns in app settings to check at logDeprecatedTransitions.
@latin-panda latin-panda linked an issue Sep 14, 2020 that may be closed by this pull request
@latin-panda latin-panda merged commit 395ddcb into master Sep 14, 2020
@latin-panda latin-panda deleted the 269-log-warning-deprecated-transitions branch June 14, 2021 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn about deprecated transitions when uploading app-settings
2 participants