Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin app shows error after successful upgrade #8940

Closed
jkuester opened this issue Mar 15, 2024 · 3 comments
Closed

Admin app shows error after successful upgrade #8940

jkuester opened this issue Mar 15, 2024 · 3 comments
Assignees
Labels
Affects: 4.6.0 Type: Bug Fix something that isn't working as intended
Milestone

Comments

@jkuester
Copy link
Contributor

Describe the bug

When using the Admin app to upgrade a CHT instance to the latest tagged version (e.g. 4.6.0-beta.3), the installation will complete successfully, but the UI will still display the installation error card.

To Reproduce

Deploy a CHT instance that can be upgraded via the Admin app (I used EKS)

In the Admin app on the Upgrades tab, select "Install" for the 4.6.0-beta.3 tag. Wait for the install to complete and see the error message (even though the installation succeeded).

image

Alternatively, instead of selecting "Install", select "Stage". Then, once the installation is staged, click "Install" and see the error (note that, for me, the page automatically updates after ~30sec to clear this screen and take me back to the normal Upgrades tab. I never see the "Deployment Complete" card, but at least the error goes away....):

image

Expected behavior

Either way, when the installation succeeds, I expect to see "Deployment complete.":

image

Logs

There are lots of errors in the console log, but I think most of them are normal while polling for the updated api server to come back online. However, as the error card appears at the end of the upgrade, I do see: main.js:1 Error triggering update instance.upgrade.error.deploy

Additional context

This behavior only seems to be happening for the 4.6.0 beta tags. If I start from an older CHT version, such as 4.3.0, and then try upgrading to 4.5.2-beta.1, I do not see any problems. Then if I upgrade to 4.6.0-beta.3, I see the error card being displayed.

@jkuester jkuester added the Type: Bug Fix something that isn't working as intended label Mar 15, 2024
@jkuester
Copy link
Contributor Author

@garethbowen now that we have resolved #8868 and there are not any session issues after upgrading, we have still been able to re-create these error display issues. My main question at this point is if you think this should block the 4.6 release? Similar behavior has been seen before on older code, but I was not able to reproduce this myself. As far as I can reproduce, this problem behavior only happens for the 4.6.0 beta tags.

@garethbowen
Copy link
Contributor

@jkuester I'm sure I've seen this before 4.6.x. either way I don't think it's a blocker.

@dianabarsan dianabarsan self-assigned this Mar 23, 2024
@dianabarsan dianabarsan moved this from Todo to In Progress in Product Team Activities Mar 24, 2024
@dianabarsan dianabarsan added this to the 4.7.0 milestone Mar 24, 2024
@dianabarsan dianabarsan moved this from In Progress to Next Week's Commitments in Product Team Activities Apr 4, 2024
@dianabarsan
Copy link
Member

Merged to master

@github-project-automation github-project-automation bot moved this from Next Week's Commitments to Done in Product Team Activities Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: 4.6.0 Type: Bug Fix something that isn't working as intended
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants