fix(#9747): throw error if outbound config is undefined #9748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianabarsan
reviewed
Jan 18, 2025
| } | ||
| }; | ||
|
|
||
| assert.throws(() => mapDocumentToPayload(doc, conf, 'test-doc'), /Mapping error/); |
There was a problem hiding this comment.
Can you please make these error assertions more specific, so we know which error is triggered. Something like:
Suggested change
| assert.throws(() => mapDocumentToPayload(doc, conf, 'test-doc'), /Mapping error/); | |
| assert.throws(() => mapDocumentToPayload(doc, conf, 'test-doc'), /Mapping error.*'expr' or 'path' is required/); |
|
@witash I see you added new commits to the PR. Is this work ready to be reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9747