-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(#9759): uplift dependency versions #9767
Open
jkuester
wants to merge
21
commits into
medic:master
Choose a base branch
from
jkuester:9759_uplift_deps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkuester
changed the title
Bump minor versions in root
chore(#9759): uplift dependency versions
Jan 30, 2025
Full yolo here.
This reverts commit 9d44db6.
jkuester
commented
Jan 31, 2025
@dianabarsan can you look at this when you have some time? Mostly it is straightforward, but you might pay special attention to:
|
dianabarsan
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate you doing this work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Docs PR: medic/cht-docs#1754
Package changes
Changed
@tsconfig/node20
to@tsconfig/node22
Targeting our current node version. Updated the cht-datasource
tsconfig.json
.Added
q
as a dev-dependency inadmin
This was needed for the unit tests which were piggy-backing on
q
in the root node_modules. This broke, though, because I guessq
was no longer getting pulled in transitively.Removed
diff
It was added in this commit, but I cannot figure out where it was ever being used... 🤔
Major version bumps
@faker-js/faker
- 8 > 9Checked migration guide. Nothing concerning as long as we are not using any deprecated functions.
@types/node
20 > 22Should be safe as Node 22 is now our base version.
cht-conf
3 > 4Just dropping support for Node < 18.
inquirer
9 > 12We do not seem to be affected by any breaking changes:
mocha
10 > 11Just dropping support for older Node versions.
node-html-parser
6 > 7Now targeting es6. Should not impact us since this is only used in api.
nyc
15 > 17Just dropping support for older Node versions.
rate-limiter-flexible
3 > 5Just dropping support for older Node versions:
shellcheck
2 > 3Just dropping support for older Node versions.
uuid
8 > 10Mostly just dropping support for old Node versions.
There are issues with going to version
11+
. Have logged #9769sinon
16 > 18Just dropping support for old Node versions and removing some deprecated code that does not affect us.
We will need to do some migration work to get to
19+
, so I have logged #9768helmet
3 > 8Not super clear why we were so behind on this one. Helmet 4 changed some things, but none of those seem to affect us (at least not anymore).
Code review checklist
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.