chore(na) Simplify macos steps to always build couchdb image #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th intel and apple silicon)
mrjones-plip
requested review from
esthermmoturi and
andrablaj
and removed request for
esthermmoturi
|
@JenniferMuli @esthermmoturi and @andrablaj - I know you both have been working on this so mentioning y'all for awareness of this change. I also note this was a recent change to the docs and there's an active forum post discussing this! |
mrjones-plip
changed the title
andrablaj
requested changes
Feb 7, 2024
There was a problem hiding this comment.
This is so much simpler and faster now, thanks @mrjones-plip! 👏 I have a small comment, but otherwise everything worked correctly.
I committed directly the removal of some text mentioning Apple Silicon section, I hope that's OK.
andrablaj
reviewed
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reduced the number of manual steps that Apple Silicon users need to take when setting up the CHT Core dev env. While it sends both Intel and Apple Silicon user through these steps, it's a safe abstraction (technically all users could take this route).
The
npm run local-imagesis a very heavy call, building every image for every service. We only want the couchDB one. As well, we don't want different env vars and docker files for macOS folks - this PR keeps all that standard.With less steps and less setup needed, I believe this will mean more success for new devs first getting setup!
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.