Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] RBAC Proxy TLS #51

Closed
wants to merge 2 commits into from
Closed

[WIP] RBAC Proxy TLS #51

wants to merge 2 commits into from

Conversation

razo7
Copy link
Member

@razo7 razo7 commented May 29, 2023

New deprecation warnings from kube-rbac-proxy container, after updating kube-rbac-proxy version to v0.14.1 in #47.
According to brancz/kube-rbac-proxy#196 TLS will be mandatory from V1 release.

In order to comply with it we add a self-signed TLS to the kube-rbac-proxy container.

*Since the secret is exposed and not encrypted, then we won't merge it ATM and we only want to test it now.

razo7 added 2 commits May 29, 2023 15:22
Deprecation warnings by #187 for insecure connection without TLS
Using OpenSSL to create RSA key and certificate. Then change to Base64
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2023

@razo7: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.14-openshift-e2e 473be80 link true /test 4.14-openshift-e2e
ci/prow/4.12-openshift-e2e 473be80 link true /test 4.12-openshift-e2e
ci/prow/4.13-openshift-e2e 473be80 link true /test 4.13-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@slintes
Copy link
Member

slintes commented May 30, 2023

Using a hardcoded, public cert and key is a bad idea. Let's discuss a better solution...

/close

@openshift-ci openshift-ci bot closed this May 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

@slintes: Closed this PR.

In response to this:

Using a hardcoded, public cert and key is a bad idea. Let's discuss a better solution...

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants