Apply Ginkgo v2 changes

Some deprecation and changes due to the major version bumping

Makefile

@@ -177,7 +177,7 @@ test: test-no-verify verify-unchanged ## Generate and format code, run tests, ge
 
 .PHONY: test-no-verify
 test-no-verify: manifests generate go-verify fmt vet envtest ginkgo ## Generate and format code, and run tests
-	ACK_GINKGO_DEPRECATIONS=$(GINKGO_VERSION) KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path --bin-dir $(LOCALBIN))" $(GINKGO) -v -r --keepGoing -requireSuite ./api/... ./controllers/... -coverprofile cover.out
+	ACK_GINKGO_DEPRECATIONS=$(GINKGO_VERSION) KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path --bin-dir $(LOCALBIN))" $(GINKGO) -v -r --keep-going -require-suite ./api/... ./controllers/... -coverprofile cover.out
 
 ##@ Bundle Creation Addition
 ## Some addition to bundle creation in the bundle

api/v1beta1/webhook_suite_test.go

@@ -132,7 +132,7 @@ var _ = BeforeSuite(func() {
 		return nil
 	}).Should(Succeed())
 
-}, 60)
+})
 
 var _ = AfterSuite(func() {
 	cancel()

controllers/suite_test.go

@@ -54,7 +54,7 @@ var _ = BeforeSuite(func() {
 
 	// call start or refactor when moving to "normal" testEnv test
 
-}, 60)
+})
 
 func startTestEnv() {
 	By("bootstrapping test environment")

hack/functest.sh

@@ -27,9 +27,9 @@ fi
 
 # -v: print out the text and location for each spec before running it and flush output to stdout in realtime
 # -r: run suites recursively
-# --keepGoing: don't stop on failing suite
-# -requireSuite: fail if tests are not executed because of missing suite
-ACK_GINKGO_DEPRECATIONS=$1 ./bin/ginkgo/$1/ginkgo $NO_COLOR -v -r --keepGoing -requireSuite ./test/e2e
+# --keep-going: don't stop on failing suite
+# -require-suite: fail if tests are not executed because of missing suite
+ACK_GINKGO_DEPRECATIONS=$1 ./bin/ginkgo/$1/ginkgo $NO_COLOR -v -r --keep-going -require-suite ./test/e2e
 
 if [[ $? != 0 ]]; then
     echo "E2e tests FAILED"