Port set-prototype-of to ext #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medikoo
requested changes
Sep 16, 2021
There was a problem hiding this comment.
@davidwallacejackson Great thanks for giving that a spin!
Please see my comments. In addition to them:
- Files as
.DS_Storeshould not be committed in - We need tests, and I know this part can be challenging, as different test suite is used in
ext. Old tests which can be found in _es5-ext/test and then need to be moved totestand refactored to new test runner (you can take inspiration from other reactors)
| @@ -0,0 +1,43 @@ | |||
| // Workaround for http://code.google.com/p/v8/issues/detail?id=2804 | |||
There was a problem hiding this comment.
To maintain changes history, ideally, if this is moved module from _es5-ext/object/create.js
| @@ -0,0 +1,7 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
This should not be introduced (we should rely on type/object/is
| @@ -0,0 +1,10 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
Those modules should be moved from _es5-ext/object/set-prototype-of
| @@ -0,0 +1,8 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
This should not be introduced (we should rely on type/value/ensure)
medikoo
reviewed
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Giving this a shot! It looks like the implementations in the
testdirectory are generated/compiled, and I haven't figured out how to build them yet -- let me know and I'd be happy to do it!