Remove phrase 'Abstract' from abstract class names #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curt-Park
reviewed
Apr 8, 2019
examples/reacher_v2/utils.py
Outdated
| @@ -7,11 +7,11 @@ | |||
|
|
|||
| import numpy as np | |||
|
|
|||
| from algorithms.common.abstract.her import AbstractHER | |||
| from algorithms.common.abstract.reward_fn import AbstractRewardFn | |||
| from algorithms.common.abstract.her import HER as AbstractHER | |||
There was a problem hiding this comment.
Why HER's class name is declared as AbstractHER, while RewardFn is not AbstractRewardFn?
|
darthegg
changed the title
darthegg
changed the title
|
How about "Remove phrase 'Abstract' from abstract class names"? |
darthegg
changed the title
Curt-Park
reviewed
Apr 11, 2019
Curt-Park
reviewed
Apr 11, 2019
darthegg
force-pushed
the
feature/remove_abstract
branch
from
d79c356
to
66a8f4a
Compare
Curt-Park
reviewed
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #131
Author: Chaehyeuk Lee
Error : Class name is same with Abstract Class name
ex) class Agent(Agent)
Fix : Change name of Agent class to include algorithm name
ex) class DQNAgent(Agent)
Change input name 'HER' to 'her'
Test all algorithms and Environments running