Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add builders to records #142

Closed
michael-82 opened this issue Jun 6, 2023 · 0 comments · Fixed by #143
Closed

Add builders to records #142

michael-82 opened this issue Jun 6, 2023 · 0 comments · Fixed by #143
Assignees
@michael-82
Labels
refactoring
Milestone
Release v4.0.0

Comments

@michael-82
Copy link
Collaborator

#74 introduced records instead of classes for API classes. They come with the default constructors only, which can be (or is) a bit cumbersome when creating instances with mostly null values.
In order to improve readability, add builders to those records and modify the calls accordingly.
@michael-82 michael-82 self-assigned this Jun 6, 2023
@michael-82 michael-82 mentioned this issue Jun 6, 2023
Merged
michael-82 added a commit that referenced this issue Jul 11, 2023
@michael-82
#142 - Add builders to records
1177b77 
- Annotate records with the lombok @builder annotation
- Convert FeasibilityIssues from class to record
michael-82 added a commit that referenced this issue Jul 11, 2023
@michael-82
#142 - Add builders to records
6380db8 
- call builders instead of constructors for records
michael-82 added a commit that referenced this issue Jul 20, 2023
@michael-82
Merge pull request #143 from medizininformatik-initiative/feature/142…
ce03806 
…-Add-builders-to-records

#142 - Add builders to records
@michael-82 michael-82 added this to the Release v4.0.0 milestone Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-82 michael-82

Labels
refactoring
Projects
None yet
Milestone
Release v4.0.0
Development

Successfully merging a pull request may close this issue.

#142 - Add builders to records medizininformatik-initiative/feasibility-backend
1 participant
@michael-82