Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Database configurable #325

Closed
juliangruendner opened this issue Aug 13, 2024 · 1 comment · Fixed by #326
Closed

Make Database configurable #325

juliangruendner opened this issue Aug 13, 2024 · 1 comment · Fixed by #326
Assignees
@michael-82

Comments

@juliangruendner
Copy link
Contributor

juliangruendner commented Aug 13, 2024 •
edited
Loading

The database used should be configurable via an env variable:

so instead of:

jdbc:postgresql://${FEASIBILITY_DATABASE_HOST:localhost}:${FEASIBILITY_DATABASE_PORT:5432}/codex_ui

should be

[**FEASIBILITY_DATABASE_POR**](jdbc:postgresql://${FEASIBILITY_DATABASE_HOST:localhost}:${FEASIBILITY_DATABASE_PORT:5432}/FEASIBILITY_DATABASE_NNAME)
@michael-82
Copy link
Collaborator

michael-82 commented Aug 14, 2024 •
edited
Loading

I assume that there shall be another variable for what currently is "codex_ui"? Not quite clear from the description tbh.
Clear now :)

michael-82 added a commit that referenced this issue Aug 14, 2024
@michael-82
#325 - Make Database configurable
dcc0007 
- add env variable for dbname in datasource url
@michael-82 michael-82 linked a pull request Aug 14, 2024 that will close this issue
#325 - Make Database configurable #326
Merged
michael-82 added a commit that referenced this issue Aug 14, 2024
@michael-82
Merge pull request #326 from medizininformatik-initiative/feature/325…
7d7be64 
…-make-database-configurable

#325 - Make Database configurable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-82 michael-82

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#325 - Make Database configurable medizininformatik-initiative/feasibility-backend
2 participants
@juliangruendner @michael-82