Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#188 - Update spring boot #189

Merged
merged 1 commit into from
Sep 11, 2023
Merged

#188 - Update spring boot #189

merged 1 commit into from
Sep 11, 2023

Conversation

michael-82
Copy link
Collaborator

@michael-82 michael-82 commented Jul 25, 2023 •
edited
Loading

@michael-82 michael-82 changed the title #188 update spring security #188 - Update spring security Jul 25, 2023
@michael-82 michael-82 changed the base branch from master to develop July 25, 2023 11:08
@michael-82 michael-82 linked an issue Jul 25, 2023 that may be closed by this pull request
Update Spring Boot #188
Closed
1 task
@michael-82 michael-82 force-pushed the feature/188-update-spring-security branch from 742fff1 to d0de0fb Compare July 25, 2023 11:24
@michael-82 michael-82 marked this pull request as ready for review July 25, 2023 11:29
@codecov
Copy link

codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #189 (fd73911) into develop (de15558) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             develop     #189   +/-   ##
==========================================
  Coverage      71.09%   71.09%           
  Complexity       481      481           
==========================================
  Files            123      123           
  Lines           2117     2117           
  Branches          98       98           
==========================================
  Hits            1505     1505           
  Misses           552      552           
  Partials          60       60
Files Changed Coverage Δ
...sibility_gui_backend/config/WebSecurityConfig.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-82 michael-82 force-pushed the feature/188-update-spring-security branch from d0de0fb to 43311c9 Compare August 30, 2023 09:39
@michael-82
Copy link
Collaborator Author

I think the benefits from updating spring security outweigh the missing test coverage on the config class.

@michael-82 michael-82 changed the title #188 - Update spring security #188 - Update spring boot Sep 7, 2023
@michael-82
#188 - Update spring boot
fd73911 
- update spring boot to 3.1.3 (including update to spring security 6.1.3)
- change request matcher definition according to https://spring.io/security/cve-2023-34035
@michael-82 michael-82 force-pushed the feature/188-update-spring-security branch from 43311c9 to fd73911 Compare September 7, 2023 07:35
EmteZogaf
EmteZogaf approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@EmteZogaf EmteZogaf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A unit test for this spring security configuration seems pointless. It should be fully tested in integration tests, which it is currently only for the positive case. But this can be part of new pull request.

@michael-82 michael-82 merged commit a855c9a into develop Sep 11, 2023
7 of 8 checks passed
@michael-82 michael-82 deleted the feature/188-update-spring-security branch September 11, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmteZogaf EmteZogaf EmteZogaf approved these changes

Assignees
No one assigned
Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Spring Boot
2 participants
@michael-82 @EmteZogaf