Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#219 - Make order of UI tree categories configurable via env var #220

Conversation

michael-82
Copy link
Collaborator

@michael-82 michael-82 commented Oct 31, 2023

A new application property app.ontologyOrder is added and linked to the env variable ONTOLOGY_ORDER. It takes a comma-separated list of entries that predefine the order of the category list.

If the variable(s) should be named differently, just let me know

@michael-82 michael-82 added the enhancement New feature or request label Oct 31, 2023
@michael-82 michael-82 self-assigned this Oct 31, 2023
@michael-82 michael-82 linked an issue Oct 31, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #220 (598e9aa) into develop (7cf36f1) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop     #220      +/-   ##
=============================================
+ Coverage      71.12%   71.17%   +0.05%     
- Complexity       481      484       +3     
=============================================
  Files            123      123              
  Lines           2116     2120       +4     
  Branches          98       98              
=============================================
+ Hits            1505     1509       +4     
  Misses           551      551              
  Partials          60       60              
Files Coverage Δ
...ty_gui_backend/terminology/TerminologyService.java 97.11% <100.00%> (+0.11%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@michael-82 michael-82 marked this pull request as ready for review October 31, 2023 11:15
@michael-82 michael-82 force-pushed the feature/219-make-order-of-ui-tree-categories-configurable-via-env-var branch from d62932d to 9464242 Compare October 31, 2023 11:15
@michael-82
Copy link
Collaborator Author

The delimiter for the env var to seperate the ui categories can be chosen by the developer.

The comma is perfectly fine as delimiter since it is then automatically converted into a list without the need for further "manual" splitting

Categories which cannot be found in the sort list should be appended at the end when the backend returns the categories

Categories that are not part of the defined order are appended at the end in alphabetical order.

- add a new env variable "ONTOLOGY_ORDER"
- adapt test for get category
@michael-82 michael-82 force-pushed the feature/219-make-order-of-ui-tree-categories-configurable-via-env-var branch from 9464242 to 598e9aa Compare November 3, 2023 08:41
@juliangruendner juliangruendner merged commit 2f5f939 into develop Nov 9, 2023
8 checks passed
@michael-82 michael-82 deleted the feature/219-make-order-of-ui-tree-categories-configurable-via-env-var branch November 14, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make order of ui-tree categories configurable via env var
2 participants