Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#260 - Endpoint modification for template and savedqueries retrieval with activated validation #264

Merged
merged 1 commit into from
Mar 19, 2024
Merged

#260 - Endpoint modification for template and savedqueries retrieval with activated validation #264

merged 1 commit into from
Mar 19, 2024

Conversation

michael-82
Copy link
Collaborator

@michael-82 michael-82 commented Mar 12, 2024 •
edited
Loading

  • Modify the endpoints to retrieve query and query templates list. By default, always include validation of the queries (can be disabled via request parameter "skipValidation" (defaults to false)
  • Remove /template/validate endpoint

⚠️ We discussed whether or not this should lead to a new api version (v4), but it was decided against doing so, even if it technically is not correct. ⚠️

@michael-82 michael-82 linked an issue Mar 12, 2024 that may be closed by this pull request
Endpoint Modification for Template and savedQueries Retrieval with activated Validation #260
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.56%. Comparing base (d8d1cbc) to head (f6d09ee).

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop     #264      +/-   ##
=============================================
- Coverage      75.66%   75.56%   -0.10%     
- Complexity       539      540       +1     
=============================================
  Files            124      124              
  Lines           2227     2218       -9     
  Branches         106      108       +2     
=============================================
- Hits            1685     1676       -9     
  Misses           478      478              
  Partials          64       64

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-82 michael-82 force-pushed the feature/260-endpoint-modification-for-template-and-savedqueries-retrieval-with-activated-validation branch 2 times, most recently from 3b849f4 to 30039f0 Compare March 18, 2024 14:50
@michael-82 michael-82 marked this pull request as ready for review March 18, 2024 14:54
@michael-82
#260 - Endpoint Modification for Template and savedQueries Retrieval …
f6d09ee 
…with activated Validation

- change query and template endpoints to include getting invalid terms by default
- this will most likely change when validation is extended to also include missing contexts or invalid filters
@michael-82 michael-82 force-pushed the feature/260-endpoint-modification-for-template-and-savedqueries-retrieval-with-activated-validation branch from 30039f0 to f6d09ee Compare March 19, 2024 09:43
@michael-82 michael-82 merged commit 32ddf69 into develop Mar 19, 2024
8 checks passed
@michael-82 michael-82 deleted the feature/260-endpoint-modification-for-template-and-savedqueries-retrieval-with-activated-validation branch March 19, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thkoehler11 thkoehler11 thkoehler11 approved these changes

@Shayan1375 Shayan1375 Shayan1375 approved these changes

Assignees

@michael-82 michael-82

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Endpoint Modification for Template and savedQueries Retrieval with activated Validation
3 participants
@michael-82 @thkoehler11 @Shayan1375