#258 - Add an endpoint that takes a structured query and validates it #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
michael-82
commented
Mar 19, 2024
•
michael-82
commented
- Return invalid criteria (termcode/context) instead of just termcode
- Replace old /validate endpoint with the new one
- add swagger documentation for the endpoint
- When no invalid terms are found, return an empty array instead of omitting the parameter
- Don't include the invalid terms list in the structured query itself but create a new object ValidatedStructuredQuery, containing the original query and the list of invalid terms
- Add a new endpoint that takes a structured query and sends back the same query with additional invalidTerms if present
- Return invalid criteria (termcode/context) instead of just termcode - Replace old /validate endpoint with the new one - add swagger documentation for the endpoint - When no invalid terms are found, return an empty array instead of omitting the parameter - Don't include the invalid terms list in the structured query itself but create a new object ValidatedStructuredQuery, containing the original query and the list of invalid terms - Add a new endpoint that takes a structured query and sends back the same query with additional invalidTerms if present
- fix a test that should mock getInvalidCriteria instead of getInvalidTermcodes - update blaze container in tests to 0.25
michael-82
force-pushed
the
feature/258-add-an-endpoint-that-takes-a-structured-query-and-validates-it
branch
from
8495361
to
83775be
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #265 +/- ##
=============================================
- Coverage 75.56% 75.48% -0.09%
- Complexity 540 543 +3
=============================================
Files 124 125 +1
Lines 2218 2235 +17
Branches 108 109 +1
=============================================
+ Hits 1676 1687 +11
- Misses 478 483 +5
- Partials 64 65 +1 ☔ View full report in Codecov by Sentry. |
- switch to invalid criteria where invalid term codes were still in place
thkoehler11
approved these changes
Mar 20, 2024
michael-82
deleted the
feature/258-add-an-endpoint-that-takes-a-structured-query-and-validates-it
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.