#266 - Change validation information #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/test/java/de/numcodex/feasibility_gui_backend/query/QueryHandlerServiceTest.java
Dismissed
Show dismissed
Hide dismissed
|
Changes to swagger doc are still missing. Rest can be used for testing already. |
- add mutable criterion and structured query classes that can be easily annotated during validation. Provide converters to convert immutable to mutable and vice versa - remove validatedstructuredquery - add validation issues - remove invalidCriteria from entities
- rename TermCodeValidation to StructuredQueryValidation - remove ValidationIssues and directly use List<ValidationIssue>
- rename getinvalidcriteria - modify tests
- add skipValidation parameter to get query and get template
michael-82
force-pushed
the
feature/266-change-validation-information
branch
from
26b08ba
to
2ca7f48
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #271 +/- ##
=============================================
+ Coverage 75.48% 77.01% +1.53%
- Complexity 543 595 +52
=============================================
Files 125 128 +3
Lines 2235 2367 +132
Branches 109 132 +23
=============================================
+ Hits 1687 1823 +136
+ Misses 483 475 -8
- Partials 65 69 +4 ☔ View full report in Codecov by Sentry. |
- increase test coverage
- modify swagger file
thkoehler11
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.