#330 - Empty filter lists lead to missing results #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-82
force-pushed
the
bugfix/330-empty-filter-lists-lead-to-missing-results
branch
2 times, most recently
from
4696a70
to
87d4f6e
Compare
- check with CollectionUtils.isNotEmpty() if the filter lists are neither null nor empty
michael-82
force-pushed
the
bugfix/330-empty-filter-lists-lead-to-missing-results
branch
from
87d4f6e
to
eaf39a9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #331 +/- ##
==========================================
Coverage 81.54% 81.54%
+ Complexity 597 596 -1
==========================================
Files 135 135
Lines 2465 2465
Branches 151 151
==========================================
Hits 2010 2010
Misses 396 396
Partials 59 59 ☔ View full report in Codecov by Sentry. |
Shayan1375
approved these changes
Aug 23, 2024
michael-82
deleted the
bugfix/330-empty-filter-lists-lead-to-missing-results
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if this solves the issue of no found results when an empty parameter for contexts, terminologies, kds-modules or criteria-sets is submitted