Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#329 - Update changelog and doublecheck swagger #336

Merged

Conversation

michael-82
Copy link
Collaborator

@michael-82 michael-82 commented Aug 21, 2024

  • Update changelog
  • remove unused imports
  • remove useless semicolons
  • change formatting for log messages
  • fix typos/grammatical errors
  • inline returnvalues where possible
  • add missing method and parameters to swagger file

@michael-82 michael-82 linked an issue Aug 21, 2024 that may be closed by this pull request
@michael-82 michael-82 force-pushed the feature/329-update-changelog-and-doublecheck-swagger branch from 2076142 to c0eb569 Compare August 21, 2024 11:48
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.54%. Comparing base (2dcaa8e) to head (6dec8f3).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #336      +/-   ##
=============================================
- Coverage      81.56%   81.54%   -0.03%     
+ Complexity       602      597       -5     
=============================================
  Files            135      135              
  Lines           2474     2465       -9     
  Branches         151      151              
=============================================
- Hits            2018     2010       -8     
+ Misses           397      396       -1     
  Partials          59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Update changelog
- remove unused imports
- remove useless semicolons
- change formatting for log messages
- fix typos/grammatical errors
- inline returnvalues where possible
@michael-82 michael-82 force-pushed the feature/329-update-changelog-and-doublecheck-swagger branch from c0eb569 to 97d7ad3 Compare August 21, 2024 12:10
@michael-82 michael-82 marked this pull request as ready for review August 21, 2024 12:23
@michael-82 michael-82 marked this pull request as draft August 21, 2024 12:24
- Add missing endpoint /query/detailed-obfuscated-result-rate-limit to swagger doc
- Add missing skipValidation parameter to get query template
@michael-82 michael-82 marked this pull request as ready for review August 21, 2024 13:53
@michael-82 michael-82 merged commit 15da2fd into develop Aug 21, 2024
7 of 8 checks passed
@michael-82 michael-82 deleted the feature/329-update-changelog-and-doublecheck-swagger branch August 21, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update changelog and doublecheck swagger
1 participant