Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#332 - Remove @Data annotation from jpa classes #345

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

michael-82
Copy link
Collaborator

@michael-82 michael-82 added the enhancement New feature or request label Aug 29, 2024
@michael-82 michael-82 linked an issue Aug 29, 2024 that may be closed by this pull request
@michael-82 michael-82 force-pushed the feature/332-remove-data-annotation-from-jpa-classes branch from 15b3e6c to 3bde47b Compare September 2, 2024 11:55
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 122 lines in your changes missing coverage. Please review.

Project coverage is 74.67%. Comparing base (6d7ab88) to head (33e4e6d).

Files with missing lines Patch % Lines
...kend/terminology/persistence/UiProfileContent.java 0.00% 10 Missing ⚠️
...bility_gui_backend/dse/persistence/DseProfile.java 0.00% 8 Missing ⚠️
...asibility_gui_backend/query/persistence/Query.java 0.00% 8 Missing ⚠️
...ty_gui_backend/query/persistence/QueryContent.java 0.00% 8 Missing ⚠️
...y_gui_backend/query/persistence/QueryDispatch.java 0.00% 8 Missing ⚠️
...y_gui_backend/query/persistence/QueryTemplate.java 0.00% 8 Missing ⚠️
...lity_gui_backend/query/persistence/SavedQuery.java 0.00% 8 Missing ⚠️
...y_gui_backend/query/persistence/UserBlacklist.java 0.00% 8 Missing ⚠️
...y_gui_backend/terminology/persistence/Context.java 0.00% 8 Missing ⚠️
...erminology/persistence/ContextualizedTermCode.java 0.00% 8 Missing ⚠️
... and 5 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #345      +/-   ##
=============================================
- Coverage      78.51%   74.67%   -3.84%     
  Complexity       547      547              
=============================================
  Files            135      149      +14     
  Lines           2374     2496     +122     
  Branches         143      220      +77     
=============================================
  Hits            1864     1864              
- Misses           453      575     +122     
  Partials          57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-82 michael-82 force-pushed the feature/332-remove-data-annotation-from-jpa-classes branch from 3bde47b to 33e4e6d Compare September 4, 2024 06:08
- Remove @DaTa and @EqualsAndHashCode annotations and replace them with @getter @Setter @tostring (excluding lazily loaded variables) and custom equals and hashcode methods
- Change id datatype from int to Long in entity classes
- Start writing tests (context.hashCode() is weird rn)
@michael-82 michael-82 force-pushed the feature/332-remove-data-annotation-from-jpa-classes branch from 33e4e6d to 1d09b0b Compare October 25, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove @Data annotation from jpa classes
1 participant