#68 - limit requesting of detailed results per user #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
michael-82
commented
Mar 10, 2023
michael-82
commented
- add a second bucket to enforce a quota on the detailed obfuscated results endpoint
- currently, returning a token back to the bucket when the actually received result was only a summary (due to whatever reason...result no longer available, too few sites responded, too few results received) is done in the afterCompletion method of the interceptor. This does however not allow modifying the headers any more. So a custom header is remaining in this case and the remaining requests variable might be 1 too low
- add a second token bucket for the detailed results endpoint - put tokens back into the bucket if the detailed result was not returned (for whatever reason)
- put a token back into a users bucket if detailed obfuscated results were requested, but only a summary was returned (due to too few responding sites) or the result was gone
- change parameter for detailed obfuscated result limit time interval to seconds instead of minutes - add integrationtest to check that limit
|
The decision to put one token back in the interceptor after handling the request was made in discussion with @juliangruendner . I am pretty sure that there might be a better way of doing this, however, I did not find it, yet. So if you have any hints here, please let me/us know. |
michael-82
deleted the
feature/68-Limit-requesting-of-detailed-results-per-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.