Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to MII Namespace #1

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Switch to MII Namespace #1

merged 3 commits into from
Mar 24, 2022

Conversation

EmteZogaf
Copy link
Collaborator

Change naming from CODEX to MII related.

@EmteZogaf EmteZogaf requested a review from DiCanio March 22, 2022 15:28
DiCanio
DiCanio approved these changes Mar 24, 2022
View reviewed changes
Copy link

@DiCanio DiCanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed some minor things:

  • path in rebuild.sh was pointing to a wrong location
  • accidentally added jar files have been removed

Other than that, changes look good.

@DiCanio
Copy link

DiCanio commented Mar 24, 2022

We also noticed that the test setup README does no longer match the actual setup.
However, since this divergence has nothing to do with the MII namespace, it is handled in a separate issue.

@EmteZogaf EmteZogaf merged commit fc41574 into main Mar 24, 2022
@DiCanio DiCanio deleted the switch-to-mii branch April 12, 2022 11:42
DiCanio added a commit that referenced this pull request Apr 12, 2022
@DiCanio
Merge pull request #1 from medizininformatik-initiative/switch-to-mii
2ae7439 
Switch to MII Namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiCanio DiCanio DiCanio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmteZogaf @DiCanio