Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update audio file names #16

Merged
merged 2 commits into from
Sep 18, 2024
Merged

refactor: Update audio file names #16

merged 2 commits into from
Sep 18, 2024

Conversation

yezhan10
Copy link
Contributor

No description provided.

@eck1001
Copy link

eck1001 commented Sep 17, 2024

The build doesn't look happy with the changed include statement:

../src/audio-codecs_wrap.cxx:1869:10: fatal error: AudioDecoderWorker.h: No such file or directory
 1869 | #include "AudioDecoderWorker.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~

@eck1001
Copy link

eck1001 commented Sep 17, 2024 •
edited
Loading

Does this build CI need to have the new medooze-media-server-src peer dep version to compile? IE: this unreleased PR: medooze/media-server#335 ?

@yezhan10
Copy link
Contributor Author

Does this build CI need to have the new medooze-media-server-src peer dep version to compile? IE: this unreleased PR: medooze/media-server#335 ?

Yes

murillo128
murillo128 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@murillo128 murillo128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@murillo128 murillo128 merged commit ee1f263 into master Sep 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murillo128 murillo128 murillo128 approved these changes

@bcostdolby bcostdolby Awaiting requested review from bcostdolby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yezhan10 @eck1001 @murillo128