Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [DIOS-6937] Use safer async wrapper with weak_ptr object lifetimes #17

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

bcostdolby
Copy link
Contributor

No description provided.

package.json Outdated Show resolved Hide resolved
src/MediaFrameListenerBridge.i Outdated Show resolved Hide resolved
@bcostdolby bcostdolby marked this pull request as ready for review September 30, 2024 06:33
@bcostdolby bcostdolby changed the title Initial changes for new async refactor: [DIOS-6937] Use safer async wrapper through weak_ptr object lifetimes Oct 1, 2024
Copy link
Collaborator

@harryz2000 harryz2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bcostdolby bcostdolby changed the title refactor: [DIOS-6937] Use safer async wrapper through weak_ptr object lifetimes refactor: [DIOS-6937] Use safer async wrapper with weak_ptr object lifetimes Oct 1, 2024
@bcostdolby bcostdolby merged commit a2ec597 into master Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants