Code quality (replicated from srt-server-node) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equivalent to medooze/srt-server-node#40 and medooze/srt-server-node#44
mildsunrise
added a commit
to medooze/video-codecs-node
that referenced
this pull request
Aug 6, 2024
replicates: medooze/audio-codecs-node#4 medooze/media-server-node#229 plus these followups: medooze/audio-codecs-node@9f1de91 medooze/audio-codecs-node@ea62f68 medooze/audio-codecs-node@beed5bd the following files were nearly identical to audio-codecs and were simply copied from there, thus do NOT require manual review: - Properties.js (completely identical) - VideoEncoderIncomingStreamTrack.js (only difference is replacing "audio" with "video" preserving case)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replicates a series of PRs that were merged in srt-server-node some week ago.
because it's pretty much a 1-to-1 correspondence, i joined them into a single PR.
i can split it if you want.