gcc's std:regex implementation seems to be buggy when char is signed as on x86. Avoid regex ranges that are of different sign. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as on x86. Avoid regex ranges that are of different sign.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sergio,
I found an issue on Ubuntu 22.04 with gcc 11 on x86-64. It seems as the std::regex implementation has issues if ranges over the sign border (0x7F to 0x80) are used like in numeric value from 0x0E to 0xFF.
Neither on Windows/Visual Studio nor on Raspi OS 64 bit the issue is happening. On Windows obsiously the std::regex implementation is different, on ARM64 the char is unsigned (while on x86-64 it's signed).
The proposed fix obviously is a work-around, but it will be necessary for Linux x86-64 I think.