Fixes Flaky export test #2022
Merged
Fixes Flaky export test #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
jamestouri
approved these changes
May 11, 2023
tonylee80
commented
May 11, 2023
| @@ -300,7 +300,7 @@ describe('System export', () => { | |||
|
|
|||
| // Output format is "ndjson", new line delimited JSON | |||
| const resourceJSON = dataRes.text.trim().split('\n'); | |||
| expect(resourceJSON).toHaveLength(3); | |||
| expect(resourceJSON.length).toBeGreaterThan(1); | |||
There was a problem hiding this comment.
The failed build is showing that the test is getting duplicated resources. It's likely caused by race conditions introduced when creating Observation resources in the test inside await waitFor. Updating the test to assert that at least more than 1 Observation resources is created.
codyebberson
approved these changes
May 11, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
reshmakh
added
the
fhir-datastore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes is a flaky test
export.testwhich is causing builds to fail:For example:
https://github.com/medplum/medplum/actions/runs/4951064553/jobs/8855536568