[CORE-942] [stripe] 3 payment intents created for 2 providers when updating cart totals

[chemicalkosek]

Bug report

Describe the bug

If there are two providers available (ie. stripe and stripe-przelewy24) and the customer is a new email, then if you update the cart totals, we end up with 3 payment intents: 2 with new totals, 1 with initial totals.
This doesn't happen when the customer already existed in stripe before starting the checkout.

System information

Medusa version (including plugins): 1.6.4, medusa-payment-stripe: 1.1.48

Steps to reproduce the behavior

1. Have two stripe providers enabled (in example stripe and stripe-przelewy24)
2. Add one item to cart.
3. Go to checkout
4. Fill in customer email. Important: must be a new stripe customer email.
5. Create payment sessions on cart
6. See two payment intents in stripe dashboard
7. Add something new to cart (new item or add shipping)
8. See three payment intents in stripe dashboard. 2 intents with new totals. 1 intent with the initial totals.

Expected behavior

2 payment intents for 2 providers with correct totals.

Screenshots

Additional context

This PR (which is included in 1.1.48) states that it should be fixed, but that's unfortunately not the case: #2603

_CORE-942

[olivermrbl]

Thanks for reporting this one @chemicalkosek.

@adrien2p Would you be up for digging a bit into this one?

[adrien2p]

Yes sure 💪

[chemicalkosek]

I have also noticed that sometimes the number of customers in that situation is doubled (same email)
1 payment intent = 2 customers
3 payment intents = 6 customers

[adrien2p]

@olivermrbl, in the cart, set payment sessions, if the total > 0 and if there is only one provider and no payment session, then we create a new session. Could it be the issue? So we update one and create a new one? could it be it? I ll test just to be sure

[olivermrbl]

@adrien2p This is solved in the latest Stripe version right? As part of #2743

[chemicalkosek]

Just tested and looks like it's still happening. Even worse.
I have something in cart. I have multiple intents created initially, but should be just two. Then after adding more stuff to cart, some more are created. Two of them have correct price.

[olivermrbl]

Thanks for sharing @chemicalkosek. We'll attend to this one.

[adrien2p]

@chemicalkosek can you share us the packages versions you are using please?

[chemicalkosek]

"medusa-payment-stripe": "^1.1.50",
"@medusajs/medusa": "^1.7.2",

[adrien2p]

@chemicalkosek I found the issue, I ll release a snapshot that you will be able to test very soon, thanks again for reporting

reference: #2921

[adrien2p]

We can see here, that with the fix, I get the customer created, the intent created and then the same intent is updated