fix(medusa-payment-stripe): missing transaction on create payment

[adrien2p]

What

Add missing transaction in the new stripe base service.
Also, now there is a number of intents equal to the number of expected sessions based on the number of providers instead of for example 3 payment intents for 2 providers.
The number of customers created on stripe is still equal to the number of intent when they are meant for different payment providers such as stripe + stripe blik

FIXES CORE-787

[changeset-bot]

🦋 Changeset detected

Latest commit: 4d922d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
medusa-payment-stripe	Patch
@medusajs/medusa	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[olivermrbl]

/snapshot-this

[adrien2p]

ready just to trigger the snap

[olivermrbl]

/snapshot-this

[github-actions]

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/medusa@0.0.0-snapshot-20221114155607

yarn add medusa-payment-stripe@0.0.0-snapshot-20221114155607

Latest commit: 3aa0827

[olivermrbl]

@adrien2p Snapshot is ready 💪

[LWJerri]

That is most likely not the issue. THis is a missing transaction on payment session creation. Your errors out on cart completion.

[olivermrbl]

Can this PR resolve the possible errors from this issue?

Yes, that is very likely! We are currently testing in staging. Feel free to give the snapshot version a go - the more tests, the merrier.

[LWJerri]

Can this PR resolve the possible errors from this issue?

Yes, that is very likely! We are currently testing in staging. Feel free to give the snapshot version a go - the more tests, the merrier.

Okay. We talk about it here - https://discord.com/channels/876835651130097704/1041669823043731466

[LWJerri]

No, it's still giving me errors.

[LWJerri]

[olivermrbl]

/snapshot-this

[github-actions]

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/medusa@0.0.0-snapshot-20221114182648

yarn add medusa-payment-stripe@0.0.0-snapshot-20221114182648

Latest commit: 3aa0827

[adrien2p]

@LWJerri can you try the last snap

[LWJerri]

@LWJerri can you try the last snap

Sure, 1 min.

[olivermrbl]

LGTM! Waiting for @LWJerri to run a test as well 💪

[LWJerri]

LGTM! Waiting for @LWJerri to run a test as well 💪

No, still get this error ;(

[chemicalkosek]

I still think @LWJerri issue is a race condition between stripe webhook completing the cart and storefront completing the cart.

[LWJerri]

I also restarted all services (back, front, admin)

lwjerri@LWJerri:~/medusa/medusa-store$ npm list
medusa-starter-default@0.0.1 /home/lwjerri/medusa/medusa-store
├── @babel/cli@7.19.3
├── @babel/core@7.20.2
├── @babel/preset-typescript@7.18.6
├── @medusajs/medusa-cli@1.3.4
├── @medusajs/medusa@0.0.0-snapshot-20221114182648
├── babel-preset-medusa-package@1.1.19
├── medusa-file-minio@1.1.1
├── medusa-file-s3@1.1.7
├── medusa-fulfillment-manual@1.1.31
├── medusa-interfaces@1.3.3
├── medusa-payment-manual@1.0.16
├── medusa-payment-paypal@1.2.6
├── medusa-payment-stripe@0.0.0-snapshot-20221114182648
└── typeorm@0.2.45

[olivermrbl]

@LWJerri Have you set up the Stripe webhook for the plugin?

[LWJerri]

@LWJerri Have you set up the Stripe webhook for the plugin?

Yes.

[LWJerri]

We can meet in Discord channel and I show you my code.

[chemicalkosek]

When he disabled webhook, then it worked for him.

[adrien2p]

Yes the amount capturable updated webhook need to be disabled for now. Is that the one?

[olivermrbl]

Alright, let's proceed in Discord. Can I get you to create a fresh entry in the help forum?

I think we should keep it out of this PR