-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(medusa-payment-stripe-processor): Start implementing the new stripe payment plugins #3257
Conversation
🦋 Changeset detectedLatest commit: 3534810 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5aef163
to
96b155e
Compare
1e7e844
to
25ebe66
Compare
fae866b
to
5307b8a
Compare
Thanks for the quick reply! There is indeed an order creation when the webhook receives an event for This also is an issue for the payment methods Blik or Przelewy24 as mentioned by @chemicalkosek in his reply here: #2948 (comment) |
@pepijn-vanvlaanderen thank you for the info, i ll discuss it and have a look to implement this 👌 cc @olivermrbl |
Thanks for sharing @pepijn-vanvlaanderen. I recall you added a similar comment on a previous PR. Sorry for not getting back on that one - I completely sweat it out. My immediate reflection on your request is that it would be reasonable to create an order in the webhook when receiving the The implementation specifics should be identical to the one of the @adrien2p and I will discuss and run a couple of test early next week of the different flows and get back :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strong work @adrien2p! 💪
The first review is centered around the webhook functionality. Will do a follow-up review for the services later today or tomorrow.
@olivermrbl I added all your feedback and some more cleanup. Let me know what you think 💪 |
@adrien2p Will do! In the meantime, please add a changeset to the PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strong work man!
…edusa into feat/stripe-payment-processor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Only minor nitpicking. Feel free to merge afterward :)
packages/medusa-payment-stripe/src/services/stripe-przelewy24.ts
Outdated
Show resolved
Hide resolved
@adrien2p Merging this one - cool? |
TODO
TEST
RESOLVE CORE-1092
RESOLVE CORE-876
RESOLVE CORE-1120