Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui,icons,ui-preset,toolbox): Move design system packages to monorepo #5470

Merged
merged 23 commits into from
Nov 7, 2023

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Oct 25, 2023

Moves all design system packages into the core monorepo under /packages/design-system.

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

🦋 Changeset detected

Latest commit: 50c0743

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
medusa-payment-stripe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 4:15pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 4:15pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 4:15pm

@kasperkristensen kasperkristensen marked this pull request as ready for review October 26, 2023 09:17
@kasperkristensen kasperkristensen requested a review from a team as a code owner October 26, 2023 09:17
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@kasperkristensen
Copy link
Contributor Author

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin@7.1.6-snapshot-20231027082759
yarn add @medusajs/admin-ui@2.1.6-snapshot-20231027082759
yarn add @medusajs/cache-inmemory@1.8.9-snapshot-20231027082759
yarn add @medusajs/cache-redis@1.8.9-snapshot-20231027082759
yarn add @medusajs/event-bus-local@1.9.7-snapshot-20231027082759
yarn add @medusajs/event-bus-redis@1.8.10-snapshot-20231027082759
yarn add @medusajs/inventory@1.11.2-snapshot-20231027082759
yarn add @medusajs/link-modules@0.2.2-snapshot-20231027082759
yarn add @medusajs/medusa@1.17.3-snapshot-20231027082759
yarn add medusa-payment-stripe@6.0.6-snapshot-20231027082759
yarn add @medusajs/modules-sdk@1.12.2-snapshot-20231027082759
yarn add @medusajs/orchestration@0.4.3-snapshot-20231027082759
yarn add @medusajs/pricing@0.1.2-snapshot-20231027082759
yarn add @medusajs/product@0.3.2-snapshot-20231027082759
yarn add @medusajs/stock-location@1.11.1-snapshot-20231027082759

Latest commit: a45da92

@olivermrbl
Copy link
Contributor

@kasperkristensen, can I get you to solve the conflicts? Should be ready to merge

@kasperkristensen
Copy link
Contributor Author

kasperkristensen commented Nov 7, 2023

@kasperkristensen, can I get you to solve the conflicts? Should be ready to merge

@olivermrbl The CI continuously fail in test-cli-with-database because it can't resolve @medusajs/ui-preset, and I haven't been able to figure out how to fix it. It seems to stem from the fact that the action uses medusa-dev, and that causes @medusajs/ui-preset to get stored somewhere in the node_modules that causes it to no longer be reachable by the tailwind config in @medusajs/admin-ui. But it of course works without any issues locally, so I am having a hard time figuring out exactly where the preset is ending up within the action, which makes it hard to figure out how to fix it 🤷 I'll try to find some time to debug it this week, but it's super painful since I can only test it against the CI and its taking close to 20 min before it gets to the point that fails.

Edit:
And now it just worked all of the sudden, I changed the versioning to workspace:^ so perhaps that made a difference. But we should properly run the tests a couple more times to make sure that it works every time, as I don't think we should merge this right now if it introduces CI flakiness.

Edit 2:
Passed 3 times in a row so I am merging 🥳

@kasperkristensen kasperkristensen merged commit e4ce2f4 into develop Nov 7, 2023
12 checks passed
@kasperkristensen kasperkristensen deleted the chore/move-medusajs-ui branch November 7, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants