Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not hide parent test that failed whereas all child tests passed #24

Merged
merged 1 commit into from
Feb 18, 2021
Merged

do not hide parent test that failed whereas all child tests passed #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion pkg/parser/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,26 @@ func ProcessEvents(evs []models.TestEvent) []models.TestGroup {
// Hide ancestors
for k, v := range gm {
for k2 := range gm {
if strings.HasPrefix(k2, fmt.Sprintf("%s/", k)) {
if strings.HasPrefix(k2, fmt.Sprintf("%s/", k)) && !veto(v, groups) {
groups[v].Hidden = true
}
}
}

return groups
}

// veto returns true is all child events pass, but parent event with pid fail.
// All other combinations will return false.
func veto(pid int, groups []models.TestGroup) bool {
parent := groups[pid]
if parent.Status != "fail" {
return false
}
for _, child := range groups {
if strings.HasPrefix(child.TestName, fmt.Sprintf("%s/", parent.TestName)) && child.Status != "pass" {
return false
}
}
return true
}