-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQL support to push test results to database file #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medyagh
reviewed
Jun 13, 2023
spowelljr
requested changes
Jun 13, 2023
medyagh
requested changes
Jun 13, 2023
medyagh
requested changes
Jun 16, 2023
medyagh
requested changes
Jun 16, 2023
medyagh
requested changes
Jun 20, 2023
medyagh
reviewed
Jun 22, 2023
spowelljr
reviewed
Jun 22, 2023
spowelljr
reviewed
Jun 22, 2023
spowelljr
reviewed
Jun 22, 2023
spowelljr
reviewed
Jun 22, 2023
spowelljr
reviewed
Jun 22, 2023
spowelljr
reviewed
Jun 22, 2023
spowelljr
reviewed
Jun 22, 2023
medyagh
requested changes
Jun 22, 2023
cmd/gopogh/main.go
Outdated
@@ -61,7 +61,7 @@ func main() { | |||
os.Exit(1) | |||
} | |||
|
|||
if *dbPath != "" || os.Getenv("DB_PATH") != "" { | |||
if *dbPath != "" || os.Getenv("DB_PATH") != "" || *dbBackend != "" || os.Getenv("DB_BACKEND") != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put this in a helper function that can read well
for example
if dbConfProvided() ...
spowelljr
reviewed
Jun 23, 2023
medyagh
reviewed
Jun 23, 2023
spowelljr
approved these changes
Jun 23, 2023
medyagh
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-db_path flag takes in path to .sql or .db file. This flag necessitates use of flag -db_backend or environment variable DB_BACKEND (e.g. sqlite)
Alternatively, if db_path is not set, one may specify the environment variable DB_PATH. The flags hold precedence over the environment variables.
Sample Input JSON File:
Docker_Linux.zip
Sample Output .db File:
output_sqlite_summary.zip
Sample output db: