#22 [Feature Request] Right click context menu instead of popup #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doneykoo
reviewed
Jul 22, 2022
| @@ -39,6 +39,7 @@ | |||
| <option value="ctrl" id="popup-dblclick-key-ctrl">Ctrl</option> | |||
| <option value="alt">Alt</option> | |||
| <option value="shift">Shift</option> | |||
| <option value="onlyRightClick">Only right click</option> | |||
There was a problem hiding this comment.
where is this "onlyRightClick" used? seems missing usage of it?
There was a problem hiding this comment.
Instead of pressing down Alt or Control now you can also ‘right click‘ and select ‘ Look up '%s' in Dictionary’ from the context menu. See the background.js and manifest.json files
|
I guess there is no longer commits since last year, is there anything that we need to do for this? |
I’m still using my fork, and it works just like the mac Lookup context menu item. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #22